atiaomar1978-hub commented on PR #25101: URL: https://github.com/apache/camel/pull/25101#issuecomment-5077336494
@davsclaus Thanks — agreed that reverse/search over history would be a nice step beyond what this PR ships. **This PR (CAMEL-24254)** intentionally scoped to configurable limits, persistence, and **↑/↓** recall for the AI prompt plus JLine-backed command history for **F6**. It does **not** include Ctrl+R (or other) interactive history search yet. **Why Ctrl+R is non-trivial in the TUI today** - **Global shortcut:** `CamelMonitor` handles **Ctrl+R** first for tape recording, so that chord never reaches the embedded JLine shell while the monitor is active. - **AI prompt (F8):** input is custom (`AiPanel`), not JLine — only Up/Down navigation is wired so far. - **Standalone JBang CLI:** outside the TUI, JLine’s usual bindings may already apply; this change set only wires history file/size for the **F6** shell path via `TuiShellHistorySupport`. **Possible follow-up (happy to take as a separate ticket/PR if you want it on the roadmap)** 1. **AI prompt:** interactive search UI (e.g. popup or inline “reverse-i-search”) — could mirror **Ctrl+E** on the SQL tab, or another binding if we keep **Ctrl+R** for tape globally. 2. **F6 shell:** when the shell panel has focus, either forward **Ctrl+R** to JLine (and relocate tape toggle), or document/use JLine’s history-search binding explicitly on the virtual terminal path. 3. **Docs/UX:** agree on one consistent story for “search history” vs “tape record” so shortcuts don’t fight each other. If you prefer **Ctrl+R** specifically for history search in shell + AI, we should decide what happens to tape recording (different chord vs only when shell/AI focused). I can open a follow-up JIRA with that breakdown unless you’d rather fold it into a later CAMEL-24254 extension. _AI-generated comment on behalf of [atiaomar1978-hub](https://github.com/atiaomar1978-hub)._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
