davsclaus commented on PR #25156: URL: https://github.com/apache/camel/pull/25156#issuecomment-5093406399
Thanks for the thorough review @gnodet! Addressed all points: **1. `subscribeConsumerBackoff*` options become dead code** — Deprecated the `subscribeConsumerBackoffMaxAttempts` and `subscribeConsumerBackoffInterval` options with `@Deprecated` annotations and Javadoc pointing to the `createConsumerBackoff*` alternatives. The Javadoc on `subscribeConsumerTopicMustExists` was also updated to reference the correct option name. **2. Retry semantics change** — The full teardown/recreate on each retry is intentional. The whole point of merging the two tasks is a single unified reconnection task visible via Camel management (TUI, CLI, Hawtio, and other tooling). A full teardown/recreate is also safer — a partially initialized consumer (created but not subscribed) can hold stale connections and state, so starting clean on each retry avoids subtle issues. **3. `reconnectPool` shutdown not in try-finally** — Applied. The do-while loop is now wrapped in try-finally so the `ScheduledExecutorService` is always shut down. **4. Missing upgrade guide entry** — Added a section in `camel-4x-upgrade-guide-4_22.adoc` documenting the merged reconnection task and deprecated options. All changes in 73ea4c6741e6. Catalog and DSL metadata regenerated. _Claude Code on behalf of Claus Ibsen_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
