atiaomar1978-hub commented on PR #25172: URL: https://github.com/apache/camel/pull/25172#issuecomment-5098486859
### Post-review update (Bugbot + Grok) Pushed commit `425158b` addressing the main findings: | Finding | Fix | |--------|-----| | Configured `--api-key` ignored during Gemini detection | `tryGemini()` uses client `apiKey` before env lookup | | Missing function-call `id` / `thoughtSignature` | Extended `ToolCall`; parse + rebuild in `buildGeminiContents` | | API key in query string | Gemini GET/POST use `x-goog-api-key` header | | `GOOGLE_API_KEY` auto-detect footgun | Auto-detect uses `GEMINI_API_KEY` only; `GOOGLE_API_KEY` when `--api-type=gemini` | | `%3AgenerateContent` / double `/v1beta` health URL | Literal `:generateContent`; Gemini explicit URL uses `isEndpointReachable` | Tests extended in `LlmClientGeminiTest` (AssertJ): URL normalization, header auth, args/signature parsing, configured-key detection. _AI-generated comment on behalf of atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
