atiaomar1978-hub commented on PR #25203: URL: https://github.com/apache/camel/pull/25203#issuecomment-5109530063
## AI review summary (Bugbot + Grok) _Review comments generated by Cursor on behalf of atiaomar1978-hub._ ### Bugbot | Severity | Location | Finding | |----------|----------|---------| | High | `BaseMainSupport#setMcpProperties` | Management host stayed `0.0.0.0` when MCP pre-enabled management — **fixed** (always apply `camel.mcp.host`; JBang sets `127.0.0.1`) | | Medium | `ManagementHttpServer#setupMcp` | MCP route not covered by management auth paths — **noted** (same as other dev consoles; `insecure:dev`) | | Medium | Catalog metadata | MCP options under `camel.main.*` — **fixed** (`PrepareCamelMainMojo` → `camel.mcp.*`) | ### Grok-style review | Severity | Finding | Status | |----------|---------|--------| | High | Origin CSRF check case-sensitive | **Fixed** (`headerIgnoreCase` + test) | | High | `--mcp` enabled `camel.server` / port clash | **Fixed** (management only) | | High | Localhost bind skipped on JBang path | **Fixed** | | High | Wrong metadata prefix | **Fixed** | | Medium | Standalone Main needs registry handler | Documented via SPI; JBang registers `EmbeddedMcpMainListener` | | Medium | MCP vs management auth | Follow-up if we want MCP behind same auth rules | Follow-up commit: `8137ab4` on this branch addresses the high-severity items above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
