atiaomar1978-hub commented on PR #25204: URL: https://github.com/apache/camel/pull/25204#issuecomment-5112307632
## Review follow-up (Grok + Bugbot) Independent **Grok** review of the diff was run; Bugbot was also requested. ### Grok findings addressed in `86432a1` | Severity | Issue | Fix | |----------|-------|-----| | Critical | Esc left the Source tab instead of canceling edit (`CamelMonitor` routes Esc to `handleEscape` before tab keys) | `SourceTab.handleEscape()` now calls `sourceViewer.cancelEdit()` and returns `true` | | Major | Tab toggled focus mid-edit → silent discard risk | Tab is swallowed while `isEditMode()` | | Major | Canceling edit on `.md` left markdown render off | Remember/restore `markdownModeBeforeEdit` | | Minor | Stale “Saved” message after opening another file | Clear `saveMessage` in `loadFile` | Extra tests added for markdown restore, cancel API, and Tab-while-editing. ### Remaining (accepted / follow-up) - Line-ending normalization (`readAllLines` → `\n`) — acceptable for v1 prototyping editor - Soft size/binary guard — future ticket - Unused `isSourceViewerEditMode` / paste-active alias cleanup — can tidy in a follow-up bugbot run _AI-generated by Cursor Agent on behalf of Omar Atie_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
