oscerd commented on PR #25198:
URL: https://github.com/apache/camel/pull/25198#issuecomment-5122742439
Thanks @gnodet — good catch, both points are valid.
**1. Upgrade guide (pollEnrich).** Corrected. It no longer claims
`pollEnrich` has "no static template resolved at build time" (it does, in
`doInit`). The guide now separates `pollEnrich` and explains why it is left
unchanged: although it resolves its static uri at build time like
`toD`/`enrich`, its per-message recipient goes through the **shared**
`ProcessorHelper.prepareRecipient` path as `recipientList`/`routingSlip` —
which must keep runtime `{{...}}` resolution. An earlier revision of this PR
did remove it there and broke `FtpProducerRecipientListIT` (it carries
`{{ftp.server.port}}` in a recipient header). Decoupling `pollEnrich` from that
shared path to align it with `toD`/`enrich` is a follow-up.
**2. Missing tests.** Added `pollEnrichPlaceholderInHeaderStillResolved()`
and `dynamicRouterPlaceholderInHeaderStillResolved()` to document the current
behaviour and guard against regressions.
The PR scope was narrowed to `toD` + `enrich` (the diff no longer touches
`PollEnricher`/`ProcessorHelper`); the description is updated to match.
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
