atiaomar1978-hub commented on PR #25265: URL: https://github.com/apache/camel/pull/25265#issuecomment-5139142981
_AI-generated comment on behalf of atiaomar1978-hub_ ## Review follow-up (Bugbot + Grok) Independent reviews were run on branch `CAMEL-24320-kamelet-virtual-threads-fix`. ### Bugbot No bugs found. ### Grok findings | Severity | Issue | Status | |----------|-------|--------| | — | Production fix (`isBound() ? get() : default`) is correct and matches `ContextValue` contract | Accepted | | High | Main-based Kamelet IT may not always select ScopedValue backend if `ContextValueFactory` loaded earlier in the same JVM | Mitigated — `ScopedValueContextValueOrElseTest` is the primary JDK 25 guard (reflection on `ScopedValueContextValue`); Kamelet IT sets `camel.threads.virtual.enabled` in a static initializer and asserts route exists after start | | Low | Document null-tolerant `orElse` on `ContextValue` javadoc | Follow-up | Reproduction confirmed per JIRA: NPE at `ScopedValue.orElse` → `Objects.requireNonNull` when `getCreateRoute()` is called from `KameletComponent.doInit` outside binding scope. Ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
