gnodet commented on code in PR #25271:
URL: https://github.com/apache/camel/pull/25271#discussion_r3690331837
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -312,40 +312,41 @@ They were not wired into the component; the `chatModel`
is autowired instead.
If you used these helpers directly, configure your `ChatModel` with
LangChain4j's own builders or Spring Boot starters
and inject it into the component.
-=== camel-langchain4j-tools
+=== camel-langchain4j-tools (deprecated)
Review Comment:
**[MEDIUM]** This section replaces the three behavioral change entries added
by CAMEL-23943 (commit 7e10b35aec4):
1. Tool-calling round trips bounded to 10 by default
2. Hallucinated tool names no longer crash the producer
3. Tool execution errors sent to LLM instead of propagating
These behavioral changes are still in the code and affect users who continue
using `langchain4j-tools` during the 4.22 transition period. The deprecation
notice should be prepended to the existing entries, not replace them.
##########
components/camel-ai/camel-langchain4j-tools/src/main/docs/langchain4j-tools-component.adoc:
##########
@@ -14,6 +15,11 @@
*{component-header}*
+[WARNING]
+====
Review Comment:
**[LOW]** `camel-ai-tool` has a proper `xref:` link but
`camel-langchain4j-agent` uses plain backtick text. Since
`langchain4j-agent-component.adoc` exists in the same doc tree, consider using
`xref:langchain4j-agent-component.adoc[camel-langchain4j-agent]` for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
