Croway commented on PR #25309: URL: https://github.com/apache/camel/pull/25309#issuecomment-5165269024
All observations addressed (1–4 land on #25306 where that code was introduced; the `@since` nit here): 1. **Publish/unpublish race** — the engine is now notified while holding the bridge lock, so map update and engine call are atomic per tool; no orphaned-tool window remains. Engine callbacks don't re-enter the bridge, so there's no deadlock exposure, and events are route-lifecycle-rate so the longer critical section is harmless. 2. **Timeout exchange accumulation** — the WARN now logs the exchange id of the non-returned exchange for operators diagnosing memory pressure. 3. **Content-Type validation** — POST without `Content-Type: application/json` is now rejected with 415 and a clear error, per the streamable HTTP spec. 4. **Unbounded `initResult().block()`** — bounded with a 30s initialization timeout, consistent with the 5s notification timeout pattern. 5. **`@since 4.22` on `McpServerFactory`** — added. 6. **`test-execution.md`** — kept as-is: it follows the existing convention of the sibling AI modules (`camel-openai/test_execution.md`, `camel-langchain4j-agent/test-execution.md`), so moving it would diverge from the pattern reviewers of those modules already know. Both branches re-verified green (unit + conformance suites) and #25309 is rebased on the updated #25306. _Claude Code on behalf of Federico Mariani_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
