oscerd opened a new pull request, #25311: URL: https://github.com/apache/camel/pull/25311
Child of CAMEL-24261 (completing CAMEL-23462 across the AWS2 producers — this is the last producer in the sweep). ## Problem With `pojoRequest=true`, `AWS2S3Producer`'s 22 pojo-capable operations (object & bucket ops, tagging, ACLs, versioning, policies) only acted when the body was the matching request type; any other body fell through the `instanceof` with no `else`, so no AWS call was made, no response was set, and the original body was returned with no error. ## Fix Each branch now throws `IllegalArgumentException` naming the required request type, e.g. `"createBucket operation requires CreateBucketRequest in POJO mode"`. ## Test `camel-aws2-s3` has no producer route/mock harness, so this is covered by a new Mockito parameterized unit test over all 22 operations. It mocks the endpoint + client and sends a wrong-typed body with `pojoRequest=true`. Because several s3 operations resolve the bucket/key *before* the pojo-type check, the test supplies `bucketName`/`keyName` so the wrong-typed body reaches the guard being exercised. Verified to fail (silent no-op) before the fix. Region-free — no localstack or real AWS. ## Docs / backport The shared 4.22 upgrade-guide entry was added with CAMEL-24263. Main only, matching the CAMEL-23462 precedent (behaviour change, shipped in a minor, not backported). --- _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
