mayurbm commented on PR #25205: URL: https://github.com/apache/camel/pull/25205#issuecomment-5169081536
All CI checks are now green. All review feedback from @gnodet and @apupier has been addressed: - Removed `InternalRouteStartupManager` changes entirely — scope is now strictly limited to `RouteService.java` as requested - Fixed `testSetUpWalksCauseChainForMessage` to use `NullPointerException` + `initCause()` so the outer exception truly has a null message, properly exercising the cause-chain walking in `extractUsefulMessage` - Switched to AssertJ assertions - Dropped `public` from test class and methods (JUnit 5 convention) - Replaced FQCNs with proper imports - Applied `mvn formatter:format impsort:sort` — EOL encoding normalised - `DefaultSupervisingRouteControllerTest` passes (was broken only by the IRSM changes, which are now removed) Could you please take another look and approve if everything looks good? @gnodet @apupier _Claude Code on behalf of @mayurbm_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
