ammachado commented on PR #25317: URL: https://github.com/apache/camel/pull/25317#issuecomment-5182684379
Addressed all 11 actionable items from @atiaomar1978-hub's automated review (Cursor BugBot + Grok): - Fixed session shutdown to drain in-flight sessions (with timeout) instead of interrupting immediately. - Fixed origin-check bypass via query strings on `/ws` (now compares the path, not the raw URI). - Bounded the session executor's queue with rejection instead of unbounded queueing. - Added `X-Frame-Options` / `Content-Security-Policy: frame-ancestors 'none'` to deny framing (clickjacking mitigation). - Handled `RejectedExecutionException` on session submit so connections close cleanly. - Fixed `awaitTermination()` to track a single shared deadline instead of allowing up to 2x the requested timeout. - Fixed the web-session quit inconsistency (`q` now quits the session consistently, matching local terminal behavior) and removed the now-dead `webSession` flag. - Disposed the `ResizeObserver` and `Terminal` instance on disconnect in the browser client instead of leaking them until reload. - Let tests substitute a lightweight session handler instead of always spawning a full `CamelMonitor` for handshake checks, and added origin coverage for `http://localhost:<port>`. - Confirmed the docs' "same keyboard shortcuts" claim is now accurate given the quit-consistency fix, so no doc change was needed there. All 861 tests in `camel-jbang-plugin-tui` pass. _Claude Code on behalf of ammachado_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
