davsclaus commented on code in PR #25203:
URL: https://github.com/apache/camel/pull/25203#discussion_r3719506102
##########
core/camel-main/src/main/java/org/apache/camel/main/HttpManagementServerConfigurationProperties.java:
##########
@@ -573,6 +577,41 @@ public HttpManagementServerConfigurationProperties
withOpenapiUiSpecPath(String
return this;
}
+ public boolean isMcpEnabled() {
+ return mcpEnabled;
+ }
+
+ /**
+ * Whether to expose dev/diagnostics MCP tools on this management server
(requires camel-mcp-server on the
+ * classpath). Currently honored only when Camel JBang registers {@code
JbangDevMcpMainListener} (for example
+ * {@code camel run --mcp}); plain camel-main users should use {@code
camel.server.mcpEnabled} for route-based MCP.
Review Comment:
This Javadoc references `camel.server.mcpEnabled` for "route-based MCP", but
that property does not exist anywhere in the codebase. This will be confusing
for users who read this and attempt to use it.
If `camel.server.mcpEnabled` is planned for a follow-up, consider removing
the reference until it ships. If it already exists elsewhere, please point me
to it.
_This review was generated by an AI agent and may contain inaccuracies.
Please verify all suggestions before applying._
##########
dsl/camel-jbang/camel-jbang-core/pom.xml:
##########
@@ -192,6 +192,35 @@
<version>${mockito-version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-platform-http-main</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-mcp-server</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.modelcontextprotocol.sdk</groupId>
+ <artifactId>mcp-core</artifactId>
+ <version>${mcp-java-sdk-version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.modelcontextprotocol.sdk</groupId>
+ <artifactId>mcp-json-jackson2</artifactId>
+ <version>${mcp-java-sdk-version}</version>
+ <scope>test</scope>
+ </dependency>
+ <!-- MCP SDK schema validation requires networknt 2.x; wiremock pulls
1.5.x without Dialects -->
Review Comment:
The comment says "requires networknt 2.x" but
`${networknt-json-schema-validator-version}` resolves to `1.5.9` (a 1.x
version). If 2.x is actually required by the MCP SDK, the version override is
insufficient. If 1.5.x works fine, the comment is misleading — consider
clarifying.
_This review was generated by an AI agent and may contain inaccuracies.
Please verify all suggestions before applying._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
