atiaomar1978-hub commented on PR #25368:
URL: https://github.com/apache/camel/pull/25368#issuecomment-5200633707
## Review feedback addressed (@davsclaus)
_AI-generated on behalf of atiaomar1978-hub via Cursor Cloud Agent._
Pushed commit `9c7fea5` with the following fixes:
### Blocking
- **Reverted unrelated `camel.jbang.mcp` catalog change** —
`catalog/camel-catalog/.../camel-jbang-configuration-metadata.json` restored to
`main` state
### Convention fixes
- **`testRawArgSchemaConversion`** — migrated to AssertJ (`assertThat`)
- **New test methods** — dropped unnecessary `public` modifier in
`AiToolParameterHelperTest`, `AiToolExecutorTest`, and
`AiToolEndpointLifecycleTest`
- **`AiToolConfiguration.copy()`** — removed redundant `copy.argSchema =
this.argSchema` (String is immutable, clone already copies the field)
### Tests (BUILD SUCCESS)
```
./mvnw -B -pl
components/camel-ai/camel-ai-tool,components/camel-ai/camel-langchain4j-agent
-am test \
-Dtest=AiToolParameterHelperTest,AiToolExecutorTest,AiToolEndpointLifecycleTest,AiToolSpecToLangChain4jTest
```
66 tests, 0 failures/errors/skipped.
CI should re-run on this push. Ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
