oscerd commented on PR #25366:
URL: https://github.com/apache/camel/pull/25366#issuecomment-5202185920
Thanks for the review. Addressed in d12c0e7 — the new
`WebsocketConstantsTest` now uses AssertJ (`assertThat(...)`) throughout.
One thing worth flagging, since the suggestion assumed AssertJ was already
usable here: `assertj-core` was **not** on the `camel-atmosphere-websocket`
test classpath. Confirmed with `mvn dependency:tree
-Dincludes=org.assertj:assertj-core`, which returned nothing for this module
(and correctly resolves `assertj-core:3.27.7:test` for a module that does
declare it, e.g. `camel-langchain4j-agent-api`).
So the change also declares it as a test dependency. The version comes from
the parent `dependencyManagement`, so it is a version-less block matching how
other modules declare it:
```xml
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
```
Flagging it explicitly because `CLAUDE.md` says AssertJ "is already
available as a test dependency in the project", which is true project-wide but
not for this module — and the project standards ask that new dependencies be
justified. Happy to revert to JUnit assertions instead if you would rather not
add the dependency to this component just for assertion style.
Module build is green: 14 tests pass, and the full reactor build from root
is clean with no regenerated-artifact drift.
---
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
