oscerd commented on PR #25367:
URL: https://github.com/apache/camel/pull/25367#issuecomment-5202421927
Thanks for the review. Addressed in ff954f9 — the three new test methods now
use AssertJ (`assertThat(...)`).
Two notes:
**1. AssertJ was not on this module's classpath.** The suggestion assumed it
was already usable here, but `mvn dependency:tree
-Dincludes=org.assertj:assertj-core` returns nothing for `camel-undertow` (and
correctly resolves `assertj-core:3.27.7:test` for a module that does declare
it, e.g. `camel-langchain4j-agent-api`). So this change also declares it as a
test dependency, version-less since the parent `dependencyManagement` supplies
it:
```xml
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
```
Flagging it because the project standards ask that new dependencies be
justified. Happy to revert to JUnit assertions if you would rather not add it
to this component just for assertion style.
**2. Only the three new methods are converted.**
`emptyPathShouldBeReplacedWithSlash` and `nonEmptyPathShouldBeKeptSame` predate
this PR and keep their JUnit `assertEquals`, per the convention that touched
code migrates without sweeping the whole file. The file therefore imports both,
with one style per method as the convention requires. Say the word if you would
prefer the whole file migrated in one go.
Module build is green: 191 tests pass, 0 failures. Full reactor build from
root is clean with no regenerated-artifact drift.
Also worth noting for the record: the earlier CI red on this PR was not a
regression. `build (17)` failed in `camel-cxf-spring-soap` with `BindException:
Address already in use` / `Soap 1.1 endpoint already registered`, and `build
(25)` was cancelled by matrix fail-fast rather than failing.
`camel-cxf-spring-soap` has no `undertow:` endpoint usage in its tests, so
`UndertowEndpoint` is not on that code path — it publishes through CXF's own
`cxf-rt-transports-http-undertow`. A re-run passed both jobs.
---
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
