davsclaus commented on code in PR #25387:
URL: https://github.com/apache/camel/pull/25387#discussion_r3729150380
##########
components/camel-ai/camel-langchain4j-embeddingstore/pom.xml:
##########
@@ -75,6 +75,12 @@
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>${langchain4j-version}</version>
+ <scope>test</scope>
Review Comment:
Is this `langchain4j` umbrella dependency actually needed? The test only
uses classes from `langchain4j-core` (already a compile dependency) and
`langchain4j-embeddings-all-minilm-l6-v2` (already a test dependency). If it's
only pulled in transitively by one of those, it can likely be removed as an
explicit dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
