atiaomar1978-hub commented on PR #25397: URL: https://github.com/apache/camel/pull/25397#issuecomment-5208728576
_AI-generated comment on behalf of atiaomar1978-hub via Cursor Cloud Agent._ Rebased onto `main` (resolved conflict with CAMEL-24332 `buildMcpTool`/annotations in `VertxMcpServerEngine`) and pushed concurrency hardening. ## Bugbot review - **Overlapping periodic maintenance** — addressed with in-flight guards (`AtomicBoolean`) so keep-alive/idle sweeps skip if a prior run is still executing. - **POST-only leak when idle TTL disabled** — documented behavior: with idle TTL `0`, POST-only sessions rely on explicit DELETE or process shutdown; keep-alive intentionally skips sessions without an SSE stream. Default config enables both mechanisms (30s keep-alive + 5m idle TTL). ## Grok review **Verdict:** request-changes → **addressed** rebase/conflicts and overlapping sweeps; `AtomicInteger` for ping failures. **Remaining nice-to-haves (non-blocking):** - Integration test for dead GET/SSE eviction via keep-alive - Stop `CamelContext` in eviction tests for cleaner teardown All targeted tests pass locally after rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
