davsclaus commented on code in PR #25398: URL: https://github.com/apache/camel/pull/25398#discussion_r3733792533
########## catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-xml-io.xsd: ########## @@ -1,4 +1,4 @@ -<?xml version="1.0" encoding="UTF-8"?><xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:tns="http://camel.apache.org/schema/xml-io"; elementFormDefault="qualified" targetNamespace="http://camel.apache.org/schema/xml-io"; version="1.0"> +<?xml version="1.0" encoding="UTF-8"?><xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:tns="http://camel.apache.org/schema/spring"; elementFormDefault="qualified" targetNamespace="http://camel.apache.org/schema/spring"; version="1.0"> Review Comment: **Critical:** This changes the `targetNamespace` and `xmlns:tns` from `http://camel.apache.org/schema/xml-io` to `http://camel.apache.org/schema/spring`, which would break the XML IO DSL and collide with `camel-spring.xsd`. This is a stale regeneration artifact — please rebase on current `main` and regenerate. ########## catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-spring.xsd: ########## @@ -5214,17 +5214,6 @@ If enabled then invalid endpoint URIs are ignored and logged instead of throwing <![CDATA[ Configures the cache size for ProducerCache which caches producers for reuse. The default cache size is 1000. Set to -1 to turn off caching. -]]> Review Comment: **Critical:** This removes the `allowedSchemes` attribute from `toD`, `enrich`, `pollEnrich`, `recipientList`, and `routingSlip` — a security feature added by CAMEL-24298 that was merged after this branch was created. This is a stale regeneration artifact. Please rebase on current `main` and regenerate the catalog to pick up these additions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
