davsclaus commented on PR #22294: URL: https://github.com/apache/camel/pull/22294#issuecomment-5277348606
I added `createSingletonService()` to the 3 factories that were genuinely missing it: - **CyberArkVaultServiceFactory** (new module, added 2026-07-25) - **DuckDbServiceFactory** (new module, added 2026-07-25) - **JaegerServiceFactory** (new module, added 2026-06-02) The other 6 from my earlier comment don't need it: - **ArtemisServiceFactory** — already has per-protocol singletons (`createSingletonVMService()`, `createSingletonAMQPService()`, etc.) - **AWSServiceFactory** — already has per-AWS-service singletons (`createSingletonS3Service()`, `createSingletonSQSService()`, etc.) - **InfinispanServiceFactory** — already has `createSingletonInfinispanService()` - **FtpServiceFactory** — embedded Apache MINA server, not testcontainers - **JDBCServiceFactory** — remote-only, no local container to share - **MessagingServiceFactory** — remote-only, parameterized local constructor _Claude Code on behalf of Claus Ibsen_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
