atiaomar1978-hub commented on PR #25495: URL: https://github.com/apache/camel/pull/25495#issuecomment-5284994176
## Bugbot / Grok self-review — findings addressed _AI-generated comment on behalf of atiaomar1978-hub (Cursor Agent)_ ### Review summary | Severity | Finding | Status | |----------|---------|--------| | Medium | `ExchangeRedeliveryEvent` omitted exception in JSON | **Fixed** in `c916abe` — includes exchange exception | | Low | `appendException` lacked defensive try/catch | **Fixed** in `c916abe` — fallback to `exceptionMessage` | | Medium | Empty `docs/yarn.lock` in repo | **Not in this PR** — file is untracked locally, not committed | | High | Unrelated `scripts/post-pr-25433-inline-replies.sh` | **Not in this PR** — untracked locally, not committed | ### Test coverage (`CamelEventJsonTest`) - Context started event (`asJSon` + `toJSon`) - Exchange failed (via EventNotifier, exception fields) - Exchange sent (endpointUri, timeTaken) - Exchange failure handling (DLQ metadata) - Exchange redelivery (attempt + exception) - Route reloaded / restarting failure - Step failed - Service startup failure - JsonObject compatibility ### Tests ```bash ./mvnw -pl core/camel-core -am test -Dtest=CamelEventJsonTest -Dsurefire.failIfNoSpecifiedTests=false ``` All 10 tests passing locally. Ready for human review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
