atiaomar1978-hub commented on PR #25497:
URL: https://github.com/apache/camel/pull/25497#issuecomment-5287759341
## Bugbot re-review follow-up
_AI-generated on behalf of atiaomar1978-hub using Cursor._
After the initial bugbot review, the following issues were addressed in
commits `39500554a24b` and `799b8ae0dbd8`:
### Fixed
1. **Route deregistration dropped MCP tools** — `republishCombinedState` now
keeps MCP-backed tools via `toolClientMap` instead of filtering by previous
route-tool names.
2. **Duplicate tools on name clash** — route tools shadow MCP tools with the
same name in the advertised tool list (route execution already took precedence).
3. **`tool-execution` rejected route-only tools** —
`OpenAIToolExecutionProducer` now accepts endpoints configured with `tags` only
(no `mcpServer.*`).
4. **MCP `returnDirect` lost after shadowing** — MCP and route
`returnDirect` flags are merged separately; MCP flags are preserved when a
route tool is removed.
5. **MCP refresh bypassed route merge** — `republishServerTools` now calls
`republishCombinedState()` after MCP reconnect / `tools/list_changed` refresh
so route-tool shadowing and `returnDirect` merging stay consistent.
### Tests re-run
```bash
./mvnw -pl components/camel-ai/camel-openai -am test \
-Dtest=OpenAIRouteToolSupportTest,OpenAIRouteToolReturnDirectTest,McpToolCallExecutorTest,OpenAIEndpointMcpToolRefreshTest
```
All passed locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
