atiaomar1978-hub commented on PR #25507: URL: https://github.com/apache/camel/pull/25507#issuecomment-5296593139
_AI-generated on behalf of atiaomar1978-hub_ Addressed Grok review findings in commits `0b38fcef` and `4ef2ca5f`: **Critical** - Regenerated catalog metadata — property is now `camel.ai.observability.enabled` (removed stale `camel.main.enabled`) - `GenAiModelResolver` uses reflection-only LangChain4j detection — removed optional `langchain4j-core` from `camel-spring-ai-chat` - ChatClient-only routes cache/extract underlying `ChatModel` at startup for observability metadata **Medium** - Entity path uses `responseEntity()` to capture token usage and response model in spans - Added `PREFIX_AI_OBSERVABILITY` to Main `GROUP_PREFIXES` - Direct `ChatResponse.getMetadata().getModel()` in span success recording - Expanded tests: ChatClient-only, entity conversion, disabled observability, token span tags All observability tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
