atiaomar1978-hub commented on PR #25508: URL: https://github.com/apache/camel/pull/25508#issuecomment-5350849569
## Review complete _AI-generated on behalf of atiaomar1978-hub_ **Verdict: Request changes** Bugbot found one **high** issue: `closeOwnedClient()` calls `close(true)` without disconnecting a still-connected client when startup fails after `connect` but before `subscribe` completes. Otherwise this is a solid fix — the old code never called `close()` on shutdown, and failed startup had no cleanup at all. Test coverage (6 tests × 2 modules) is good for the happy/error paths tested. Thanks @nkokitkar for scoping to consumers only and preserving shared-client ownership semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
