atiaomar1978-hub commented on code in PR #25557:
URL: https://github.com/apache/camel/pull/25557#discussion_r3825030210
##########
.github/workflows/package-native-validation.yml:
##########
@@ -21,13 +21,15 @@ on:
push:
branches:
- main
+ - camel-4.22.x
paths:
- 'dsl/camel-jbang/camel-launcher/**'
- 'tooling/camel-exe/**'
- '.github/workflows/package-native-validation.yml'
pull_request:
branches:
- main
+ - camel-4.22.x
Review Comment:
**Why posix-validator fails on this PR**
This file is in the workflow `paths` filter, so editing it triggers the job.
The job then runs `mvn ... camel-repackager-maven-plugin install` which needs
`camel-buildtools:4.22.1-SNAPSHOT` from Apache Snapshots — not published yet.
The branch trigger change is correct; the failure is missing snapshot
artifacts, not bad YAML.
##########
.github/workflows/camel-launcher-native-exe.yml:
##########
@@ -32,6 +33,7 @@ on:
pull_request:
branches:
- main
Review Comment:
**Why camel-launcher-native fails**
Same pattern: workflow file change triggers the job. Pre-flight curl for
`camel-launcher/4.22.1-SNAPSHOT/maven-metadata.xml` returns 404 because the
maintenance-branch snapshot line hasn't been deployed yet. `camel-exe` passes
because it builds locally; `camel-launcher-native` resolves upstream from
snapshots.
##########
.github/workflows/pr-build-main.yml:
##########
@@ -21,6 +21,7 @@ on:
pull_request:
branches:
- main
+ - camel-4.22.x
Review Comment:
**Correct addition — note paths-ignore**
Adding `camel-4.22.x` here is the most important change for
maintenance-branch PR CI. This PR won't exercise it automatically
(`paths-ignore: .github/**`). Use `workflow_dispatch` to smoke-test after merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
