oscerd opened a new pull request, #25566:
URL: https://github.com/apache/camel/pull/25566

   Fixes [CAMEL-24413](https://issues.apache.org/jira/browse/CAMEL-24413).
   
   ## Problem
   
   CAMEL-23414 introduced 
`HazelcastSerializationFilterHelper.applyDefault(Config)` and called it from 
every place where camel-hazelcast bootstraps its own managed Hazelcast instance:
   
   - `HazelcastAggregationRepository.doStart()`
   - `HazelcastIdempotentRepository`
   - `HazelcastDefaultComponent`
   - `HazelcastUtil`
   
   `ReplicatedHazelcastAggregationRepository.doStart()` builds its `Config` the 
same way but was missed. It overrides `doStart()` **without calling 
`super.doStart()`**, so the parent's call never runs — a route using the 
replicated repository without injecting its own `hazelcastInstance` gets 
different defaults from every sibling bootstrap site.
   
   ## Change
   
   - Add the missing `HazelcastSerializationFilterHelper.applyDefault(cfg)` 
call so all five bootstrap sites behave identically.
   - Add `HazelcastAggregationRepositorySerializationFilterTest`, which asserts 
**both** bootstrap paths (plain and replicated) end up with the default 
`JavaSerializationFilterConfig`, so the two cannot drift apart again. Verified 
it actually catches the regression: with the fix reverted, 
`replicatedLocallyInitializedInstanceCarriesTheDefaultFilter` fails on a null 
filter config; with the fix, both pass.
   - Add a 4.23 upgrade-guide entry. Worth noting the CAMEL-23414 entries in 
the 4.14/4.18/4.21 guides enumerate `HazelcastAggregationRepository` and 
`HazelcastIdempotentRepository` as covered but never mentioned the replicated 
repository — the guide documented behaviour it did not have.
   
   A user-supplied `JavaSerializationFilterConfig` is still respected and never 
overwritten (unchanged helper behaviour).
   
   ## Backport
   
   Intended for **camel-4.22.x, camel-4.18.x and camel-4.14.x**, matching 
CAMEL-23414's own backports. The upgrade-guide entry stays on `main` per the 
project's guide policy.
   
   ## Testing
   
   ```
   mvn test -Dtest=HazelcastAggregationRepositorySerializationFilterTest   # 2 
passed
   mvn clean install -DskipTests                                          # 
full reactor, BUILD SUCCESS
   ```
   
   ---
   _Claude Code on behalf of 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to