oscerd opened a new pull request, #2963:
URL: https://github.com/apache/camel-kamelets/pull/2963
Fixes #2959
Two credential-metadata cleanups.
### 1. `format: password` on 13 declarations
The authoring convention is `format: password` **plus** `x-descriptors:
[urn:camel:group:credentials]`. These 13 had the descriptor but not the format:
- `serviceAccountKey` (8): `google-bigquery-sink`, `google-functions-sink`,
`google-pubsub-sink`, `google-pubsub-source`, `google-storage-sink`,
`google-storage-source`, `google-storage-event-based-source`,
`google-vertexai-sink`
- `personal-token` (5): `jira-add-comment-sink`, `jira-add-issue-sink`,
`jira-source`, `jira-transition-issue-sink`, `jira-update-issue-sink`
Sibling `password` properties in the same files were already marked, so this
looks like drift.
> **One point for a reviewer:** the 8 `serviceAccountKey` properties are
`type: binary`, and there is no existing `type: binary` + `format: password`
pairing anywhere in the catalog. I applied it because the documented convention
states it without a type carve-out and the value is a secret either way — but
if `binary` is meant to be handled differently by tooling, say so and I will
drop those 8 and keep only the 5 `type: string` jira ones.
### 2. Databricks token no longer duplicated into the URL
Both Kamelets already set `password: '{{accessToken}}'` on the
`BasicDataSource`. The token was carried a second time inside `url`, which is
an ordinary non-secret string that surfaces in JMX and in connection-failure
messages.
```diff
+ username: 'token'
password: '{{accessToken}}'
- url: '...;ssl=1;UID=token;PWD={{accessToken}}{{extraOptions}}'
+ url: '...;ssl=1{{extraOptions}}'
```
`UID=token` moves to a `username` property so the driver still gets it.
> **Not verified against a live instance:** I have not confirmed that the
Databricks JDBC driver picks up DataSource-level user/password under
`AuthMech=3` rather than requiring `UID`/`PWD` in the URL. This needs a check
against a real endpoint before merge. If the driver requires them in the URL,
the alternative is to leave the URL alone and drop the redundant `password`
property instead.
### Verification
- `script/validator` reports no errors
- `mvn verify` passes
- No live-endpoint testing performed
A co-occurrence check in `kamelets-maven-plugin` would stop the
`format`/`x-descriptors` drift recurring; happy to add it as a follow-up.
---
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
