oscerd commented on PR #25621: URL: https://github.com/apache/camel/pull/25621#issuecomment-5394451841
Thanks for the review @gnodet — all four observations are addressed in f7ff00a: 1. **`java-spiffe-version` placement** — moved to its alphabetical slot among the other `java-*` properties (between `java-grok-version` and `java-util-version`) in `parent/pom.xml`, out of the Spring block. 2. **FQCN `@Metadata`** — now imported (`org.apache.camel.spi.Metadata`) and used as the simple name in `SpiffeEndpoint`. 3. **`validateJwtSvid` body-fallback coverage** — added `validateJwtSvidTokenFromBody`, which puts the token on the message body with no `CamelSpiffeToken` header and asserts the validated SVID. 4. **Multi-audience / comma-parsing coverage** — added `fetchJwtSvidMultipleAudiences` using `"aud1, aud2, aud3"` (with spaces) to exercise both the split/trim in `resolveAudiences` and the `audiences.length > 1` varargs branch in `fetchJwtSvid`. Module tests are green (7/7) and a full-reactor `install -DskipTests` produced no catalog/DSL drift, so the import swap and property move are metadata-neutral. On the PR metadata: milestone set to `4.23.0` and the `core` label removed (the core-side changes are only generated catalog/DSL/main artifacts). The deferred `SSLContextParameters`-backed Workload-API mTLS remains tracked on CAMEL-23305 for a later increment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
