This is an automated email from the ASF dual-hosted git repository.
oscerd pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-kamelets.git
The following commit(s) were added to refs/heads/main by this push:
new ad1929ad2 Fix #2958: bind the declared queueURL property and align
precondition fallbacks with schema defaults (#2965)
ad1929ad2 is described below
commit ad1929ad20ea3f4f2c9ae502956f509a27f4cb9f
Author: Andrea Cosentino <[email protected]>
AuthorDate: Mon Aug 24 18:40:10 2026 +0200
Fix #2958: bind the declared queueURL property and align precondition
fallbacks with schema defaults (#2965)
queueURL was declared in aws-sqs-source and aws-s3-event-based-source but
referenced nowhere in either template, so setting it had no effect and
produced no warning. Bind it to the aws2-sqs queueUrl option and describe
what that option actually does.
Five preconditions used ${properties:X:true} as the fallback while the
schema declared default: false for the same property. Whether the fallback
is ever reached depends on the consuming runtime materialising schema
defaults first; aligning the fallback with the declared default is correct
either way. The azure-storage-blob-source case defaulted to deleting the
blob.
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
---
kamelets/aws-s3-event-based-source.kamelet.yaml | 7 +++++--
kamelets/aws-sqs-source.kamelet.yaml | 5 ++++-
kamelets/azure-storage-blob-event-based-source.kamelet.yaml | 2 +-
kamelets/azure-storage-blob-source.kamelet.yaml | 2 +-
kamelets/google-storage-event-based-source.kamelet.yaml | 2 +-
kamelets/set-kafka-key-action.kamelet.yaml | 2 +-
6 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/kamelets/aws-s3-event-based-source.kamelet.yaml
b/kamelets/aws-s3-event-based-source.kamelet.yaml
index 86d140e24..3d4b392be 100644
--- a/kamelets/aws-s3-event-based-source.kamelet.yaml
+++ b/kamelets/aws-s3-event-based-source.kamelet.yaml
@@ -121,7 +121,9 @@ spec:
default: https
queueURL:
title: Queue URL
- description: The full SQS Queue URL
+ description: The full SQS Queue URL. When set, it is used verbatim and
every
+ other property that would otherwise determine the queue URL is
ignored.
+ Intended for connecting to a mock SQS implementation.
type: string
uriEndpointOverride:
title: Overwrite Endpoint URI
@@ -174,6 +176,7 @@ spec:
amazonAWSHost: '{{?amazonAWSHost}}'
protocol: '{{?protocol}}'
uriEndpointOverride: '{{?uriEndpointOverride}}'
+ queueUrl: '{{?queueURL}}'
overrideEndpoint: '{{overrideEndpoint}}'
delay: '{{delay}}'
greedy: '{{greedy}}'
@@ -181,7 +184,7 @@ spec:
- choice:
precondition: true
when:
- - simple: '${properties:getObject:true}'
+ - simple: '${properties:getObject:false}'
steps:
- unmarshal:
json:
diff --git a/kamelets/aws-sqs-source.kamelet.yaml
b/kamelets/aws-sqs-source.kamelet.yaml
index 01ce9f66d..342d320c9 100644
--- a/kamelets/aws-sqs-source.kamelet.yaml
+++ b/kamelets/aws-sqs-source.kamelet.yaml
@@ -84,7 +84,9 @@ spec:
default: https
queueURL:
title: Queue URL
- description: The full SQS Queue URL.
+ description: The full SQS Queue URL. When set, it is used verbatim and
every
+ other property that would otherwise determine the queue URL is
ignored.
+ Intended for connecting to a mock SQS implementation.
type: string
useDefaultCredentialsProvider:
title: Default Credentials Provider
@@ -222,6 +224,7 @@ spec:
useProfileCredentialsProvider: "{{useProfileCredentialsProvider}}"
useSessionCredentials: "{{useSessionCredentials}}"
uriEndpointOverride: "{{?uriEndpointOverride}}"
+ queueUrl: "{{?queueURL}}"
profileCredentialsName: "{{?profileCredentialsName}}"
sessionToken: "{{?sessionToken}}"
overrideEndpoint: "{{overrideEndpoint}}"
diff --git a/kamelets/azure-storage-blob-event-based-source.kamelet.yaml
b/kamelets/azure-storage-blob-event-based-source.kamelet.yaml
index 5df537692..da76bc072 100644
--- a/kamelets/azure-storage-blob-event-based-source.kamelet.yaml
+++ b/kamelets/azure-storage-blob-event-based-source.kamelet.yaml
@@ -132,7 +132,7 @@ spec:
- choice:
precondition: true
when:
- - simple: '${properties:getBlob:true}'
+ - simple: '${properties:getBlob:false}'
steps:
- setBody:
simple: ${body.toString()}
diff --git a/kamelets/azure-storage-blob-source.kamelet.yaml
b/kamelets/azure-storage-blob-source.kamelet.yaml
index de2421672..959a0a933 100644
--- a/kamelets/azure-storage-blob-source.kamelet.yaml
+++ b/kamelets/azure-storage-blob-source.kamelet.yaml
@@ -179,7 +179,7 @@ spec:
- choice:
precondition: true
when:
- - simple: '${properties:deleteAfterRead:true}'
+ - simple: '${properties:deleteAfterRead:false}'
steps:
- to:
uri:
"azure-storage-blob:{{accountName}}/{{containerName}}"
diff --git a/kamelets/google-storage-event-based-source.kamelet.yaml
b/kamelets/google-storage-event-based-source.kamelet.yaml
index f7d0b0cd4..801eed62a 100644
--- a/kamelets/google-storage-event-based-source.kamelet.yaml
+++ b/kamelets/google-storage-event-based-source.kamelet.yaml
@@ -97,7 +97,7 @@ spec:
- choice:
precondition: true
when:
- - simple: '${properties:getObject:true}'
+ - simple: '${properties:getObject:false}'
steps:
- setProperty:
name: google-storage-event-type
diff --git a/kamelets/set-kafka-key-action.kamelet.yaml
b/kamelets/set-kafka-key-action.kamelet.yaml
index 4ea8986b0..9342abac9 100644
--- a/kamelets/set-kafka-key-action.kamelet.yaml
+++ b/kamelets/set-kafka-key-action.kamelet.yaml
@@ -57,7 +57,7 @@ spec:
- choice:
precondition: true
when:
- - simple: '${properties:forceHeaderDeletion:true}'
+ - simple: '${properties:forceHeaderDeletion:false}'
steps:
- removeHeader:
name: "{{headerName}}"
