oscerd opened a new pull request, #25640: URL: https://github.com/apache/camel/pull/25640
`IBMSecretsManagerPropertiesFunction.doStart()` inverted its credential check: it only built the client when **both** `CAMEL_VAULT_IBM_TOKEN` and `CAMEL_VAULT_IBM_SERVICE_URL` were *empty*, and threw otherwise. So a user who set those documented environment variables (the first config method in the class Javadoc, and the norm in containers/Kubernetes) got a startup failure telling them to set credentials they already set — the env-var configuration path was unusable. Now the env vars are used when present, the vault configuration is the fallback when both are empty, the client is built when a token + service URL are available from either source, and it throws only when neither provides them (matching the aws2/google secrets-manager properties functions). Control-flow fix over `System.getenv`; the existing coverage is integration-only (needs a live IBM Secrets Manager), so no unit test is added. Module build green. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
