oscerd opened a new pull request, #25650:
URL: https://github.com/apache/camel/pull/25650
# CAMEL-24471 / CAMEL-24472: two minor fixes in camel-ibm-secrets-manager
Two small, independent defects in the IBM Secrets Manager component, bundled
into one PR.
## CAMEL-24471 — copy-pasted producer header descriptions
In `IBMSecretsManagerConstants`:
- `CamelIbmSecretsManagerSecretId` was documented as _"Set the desired
secret version as header."_ — a copy of the `SecretVersion` header's
description — even though the producer reads it as the **secret id** (for the
get/delete operations).
- `CamelIbmSecretsManagerSecretName` was documented as _"Set the desired
secret path as header."_ which is likewise misleading.
Both descriptions now describe the header accurately. Metadata-only change;
the component's generated JSON descriptor is regenerated.
## CAMEL-24472 — half-configured endpoint passes validation
`IBMSecretsManagerComponent.createEndpoint()` validated the credentials with
`&&`:
```java
if (epConfiguration.getServiceUrl() == null && epConfiguration.getToken() ==
null) {
throw new IllegalArgumentException("Service URL and Token must be
specified");
}
```
so the exception fired only when **both** were missing. An endpoint
configured with just one of the two passed and then failed later with a less
clear error. The message says both are required, so the check now uses `||`
(fires when either is missing).
## Testing
Metadata/validation changes; verified with a module build (`BUILD SUCCESS`).
The generated `ibm-secrets-manager.json` descriptor is regenerated and
committed.
---
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
