oscerd commented on code in PR #25737:
URL: https://github.com/apache/camel/pull/25737#discussion_r3860446962
##########
components/camel-ibm/camel-ibm-watson-speech-to-text/src/main/java/org/apache/camel/component/ibm/watson/stt/WatsonSpeechToTextProducer.java:
##########
@@ -100,15 +101,18 @@ private void recognize(Exchange exchange) throws
Exception {
// Get audio input from header or body
File audioFile =
exchange.getIn().getHeader(WatsonSpeechToTextConstants.AUDIO_FILE, File.class);
InputStream audioStream = null;
+ boolean ownStream = false;
Review Comment:
Thanks — agreed. Today the camel-ibm-* producer modules are
integration-test-only (no Mockito), so "verified by module build + manual
reasoning" is the accepted practice for this kind of resource-lifecycle fix,
and pulling in Mockito solely for a one-line leak fix wasn't justified here.
Adding Mockito to give these modules unit-test coverage for leak/lifecycle
fixes is a reasonable follow-up if there's appetite — happy to file it
separately.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
