oscerd commented on issue #9053: URL: https://github.com/apache/camel-quarkus/issues/9053#issuecomment-5422762453
Withdrawing this one — the code is real, but the extension is not built or shipped, so there is nothing to fix here today. `avro-rpc` is disabled across the board: - `extensions/pom.xml:47` — `<!--<module>avro-rpc</module> https://github.com/apache/camel-quarkus/issues/4462 -->` - `integration-tests/pom.xml:60` — module commented out - `poms/bom/pom.xml` — both `camel-quarkus-avro-rpc` and `camel-quarkus-avro-rpc-deployment` entries commented out - `QuarkusRuntimeProviderTest` excludes `"avro-rpc"` with "can be removed after fixing #4462" - there is no `docs/modules/ROOT/pages/reference/extensions/avro-rpc.adoc` It is also stale rather than merely disabled: `extensions/avro-rpc/pom.xml` still declares parent version `3.0.0-SNAPSHOT` while `main` is at `3.40.0-SNAPSHOT`. Re-enabling the module in the reactor fails before compilation even starts: ``` Non-resolvable parent POM for org.apache.camel.quarkus:camel-quarkus-avro-rpc-parent:3.0.0-SNAPSHOT: Could not find artifact org.apache.camel.quarkus:camel-quarkus-extensions:pom:3.0.0-SNAPSHOT ``` So a patch to `VertxHttpServer` could not be compiled, let alone tested, and no user can reach the code. I had a fix written (a `quarkus.camel.avro-rpc.max-body-size` option plus bounded aggregation returning `413`) and am not proposing it, because shipping an unverifiable change to dead code is worse than leaving it. Closing as blocked on #4462. If avro-rpc is ever revived, the unbounded `rc.bodyHandler(...)` in `VertxHttpServer.start` is worth fixing as part of that work — the server is created outside the Quarkus HTTP layer, so `quarkus.http.limits.max-body-size` does not apply to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
