mayurbm commented on code in PR #25771:
URL: https://github.com/apache/camel/pull/25771#discussion_r3867780383
##########
core/camel-support/src/main/java/org/apache/camel/support/AbstractExchange.java:
##########
@@ -496,7 +497,14 @@ public <T> T getIn(Class<T> type) {
}
// fallback to use type converter
- return context.getTypeConverter().convertTo(type, this, in);
+ TypeConverter tc = context.getTypeConverter();
+ if (tc == null) {
Review Comment:
Fixed. Reverted the per-call-site guard here and in getOut(). Instead,
DefaultCamelContextExtension.resetTypeConverter() now installs a
StoppedTypeConverter sentinel. All ~200 unguarded getTypeConverter() call sites
are fixed at once.
##########
core/camel-support/pom.xml:
##########
@@ -71,6 +71,17 @@
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.assertj</groupId>
+ <artifactId>assertj-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
Review Comment:
Fixed. Removed assertj-core and mockito-core from camel-support/pom.xml. The
test has been moved to camel-core (StoppedTypeConverterTest) which already has
AssertJ. No Mockito used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
