ramu11 commented on PR #25778:
URL: https://github.com/apache/camel/pull/25778#issuecomment-5435654456
Thanks for the review, Claus. I’ve addressed the review comments:
- Shutdown race: synchronized engine registration and shutdown using a
ReentrantLock, while keeping engine creation outside the lock. Added lifecycle
tests covering concurrent evaluation and stop()/start() scenarios.
- Generic evaluate() bindings: added validation for JavaScript binding
names, including invalid identifiers and reserved words, with appropriate
ExpressionEvaluationException handling. Added corresponding tests. Route DSL
bindings remain unchanged.
- JSON/Preview design: confirmed that the current implementation
intentionally uses data-only JSON snapshots. Live Camel objects are not exposed
to QuickJS; a host-object/builtins bridge is outside the current Preview scope.
The documentation has been clarified accordingly.
- Commit message: updated to follow the Camel convention: CAMEL-23398: Add
QuickJS language.
The changes have been rebased onto the latest main, and the PR currently
contains a single commit. Relevant QuickJS tests and source checks are passing.
Thanks again for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
