oscerd opened a new pull request, #25824:
URL: https://github.com/apache/camel/pull/25824

   Fixes [CAMEL-24443](https://issues.apache.org/jira/browse/CAMEL-24443).
   
   KnativeSslClientOptions.configureOptions() installed 
TrustAllOptions.INSTANCE - a
   trust manager that accepts every certificate - whenever 
camel.knative.client.ssl.enabled
   was true and neither truststore.path nor trust.cert.path was set. No option 
named
   trustAll was involved: enabling TLS was itself what turned certificate 
validation off.
   Hostname verification in the same method already defaults to true, so the 
trust
   decision was the outlier, and KnativeOidcClientOptions extends this class.
   
   Leave the trust options unset in that case instead, so the JVM default trust 
anchors
   apply - the fallback SSLContextParameters and the rest of Camel use. 
Accepting any
   certificate stays available behind the new 
camel.knative.client.ssl.trust.all property,
   which defaults to false.
   
   KnativeHttpTest.testSecureClientOptionsPropertyConf configures SSL entirely 
through
   properties against a self-signed test server, so it relied on the old 
fallback; it now
   sets trust.all explicitly, which is the same migration an affected 
deployment makes.
   
   Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
   Signed-off-by: Andrea Cosentino <[email protected]>
   \n## Verification\n\n4 files changed, including 2 test file(s). Module build 
with \`-am\` is green on current main, no generated-file drift. Verified 
against the pre-fix code when the change was written.
   
   _Claude Code on behalf of oscerd_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to