atiaomar1978-hub commented on PR #1907:
URL: 
https://github.com/apache/camel-spring-boot/pull/1907#issuecomment-5465289752

   ## Review feedback addressed
   
   Thanks @Croway and @davsclaus for the detailed review on 
[CAMEL-24532](https://issues.apache.org/jira/browse/CAMEL-24532).
   
   This commit addresses @Croway's follow-up feedback:
   
   1. **`EarlyResolutionPropertySources`** — added 
`hasHigherPrecedenceProperty()` and 
`shouldSkipBecauseHigherPrecedenceDefines()` (DEBUG log includes property key 
and source name only, never the value). Only concrete `MapPropertySource` 
entries are compared.
   2. **All eight early-resolution parsers** — guard runs **before** contacting 
vault/jasypt/spring-cloud-config backends, skipping resolution when a 
higher-precedence source already defines the same key.
   3. **Regression tests** — core unit tests cover the higher-precedence plain 
value + lower-precedence placeholder scenario; 
`SpringBootHashicorpVaultPropertiesParserPrecedenceTest` exercises the 
Hashicorp parser directly (Testcontainers-backed when Docker is available).
   
   Commit: `4cf1c53` — please re-review when CI is green.
   
   _AI-generated on behalf of atiaomar1978-hub_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to