davsclaus opened a new pull request, #25904:
URL: https://github.com/apache/camel/pull/25904

   ## Summary
   
   
`RouteControlledStreamObserverTest.unsupportedEndpointConfigurationFailureTest` 
started failing on `main` (seen on `BuildAndTest / Matrix - jdk_25_latest / 
ubuntu-avx`) since CAMEL-24404 (#25554) merged. That change made 
`InternalRouteStartupManager.doStartOrResumeRouteConsumers()` always wrap 
consumer startup failures in `FailedToStartRouteException`.
   
   The test did:
   
   ```java
   assertThrows(IllegalArgumentException.class, camelContext::start);
   ```
   
   `GrpcConsumer.initializeServer()` still throws the raw 
`IllegalArgumentException` for the unsupported `AGGREGATION` + 
`routeControlledStreamObserver` combination, but `camelContext.start()` now 
wraps it in `FailedToStartRouteException`, so the assertion no longer matched 
the actual thrown type.
   
   This is the same regression class as #25903 (fixed for `camel-smb`): #25554 
updated 7 modules for this wrapping change but this gRPC test lives outside 
that PR's scope and was missed.
   
   ## Fix
   
   ```java
   FailedToStartRouteException exception = 
assertThrows(FailedToStartRouteException.class, camelContext::start);
   assertInstanceOf(IllegalArgumentException.class, exception.getCause());
   ```
   
   This matches the pattern already used in 
`DefaultSupervisingRouteControllerTest` (one of the tests #25554 itself 
updated).
   
   I checked the rest of `camel-grpc`'s tests for other exception assertions 
around `camelContext.start()` / `context.start()` — `GrpcProducerSecurityTest` 
also has a try/catch, but it wraps a producer call (`template.requestBody`), 
not route startup, so it's unaffected.
   
   ## Test plan
   
   - [x] `mvn -o compile test-compile` in `components/camel-grpc` — compiles 
clean
   - [x] `mvn -o test -Dtest=RouteControlledStreamObserverTest` — all 7 tests 
pass
   - [x] `mvn formatter:format impsort:sort` — no changes needed
   
   _Claude Code on behalf of davsclaus_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to