atiaomar1978-hub commented on PR #25893: URL: https://github.com/apache/camel/pull/25893#issuecomment-5470566723
@gnodet @davsclaus Review feedback addressed in commit `2b7665c4716`. **@gnodet observations:** 1. **Test stub shadowing** — Removed the redundant `TransientAiException` test stub from `camel-spring-ai-chat`. The real `spring-ai-retry` class is on the test classpath (via `spring-ai-ollama`); `SpringAiChatErrorMetadataTest` still passes against the real exception type. 2. **Two-pass classification rationale** — Added Javadoc on `GenAiErrorSupport.classify()` explaining why provider-specific mappings run first and generic Spring AI wrappers are a second pass (so e.g. `TransientAiException` → `RateLimitException` resolves to `RATE_LIMIT`, not coarse `SERVER_ERROR`). **@davsclaus follow-up (prior commit `817a50e9dd3`):** Catalog doc mirrors regenerated for all five component pages; missing doc sections added. CI is green on the latest push. Ready for re-review. _AI-generated on behalf of atiaomar1978-hub (Cursor Cloud Agent)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
