oscerd commented on PR #25873: URL: https://github.com/apache/camel/pull/25873#issuecomment-5478344453
Thanks for the review, and for tracing the `resolveExistingPathSegments` algorithm by hand rather than taking the tests' word for it. On the three notes: 1. **Assertion style** — agreed, and deliberate: each new test follows the convention of the file it lands in, which is why the Azure additions are JUnit and the Google ones AssertJ. The project guidance says not to mix styles within a file, and that reads to me as outranking the general AssertJ preference for a couple of added cases. 2. **Duplication of `resolveExistingPathSegments`** — you are right that it is verbatim in both helpers. I left it duplicated because the only shared home would be `camel-support`, and putting a storage-specific path-containment helper into core is a bigger decision than this fix should make on its own. If a third component needs the same thing, that becomes the moment to extract it. 3. **`camel-file` / `camel-smb` / `camel-ftp-common`** — noted; those are outside this PR's scope, which is Azure and Google Storage per the two JIRAs. I will look at them separately rather than widen this changeset. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
