mayurbm commented on PR #25907: URL: https://github.com/apache/camel/pull/25907#issuecomment-5476768764
@davsclaus @gnodet After reflecting on the review feedback across multiple rounds, we are closing this PR. The core issue is that the concurrency claim cannot be proven cleanly: - The original "concurrent disconnect() races with poll()" scenario was incorrect as davsclaus identified - The revised scenario via `scheduler.concurrentConsumers`/`scheduler.poolSize` is theoretically possible but the fix is incomplete — `retrieveMessages()` and `retrieveAllMessages()` still read the `folder` instance field directly - A proper fix for full poll() thread-safety would require a `synchronized` block or architectural changes, which is a broader scope than this PR - The test manufactured the precondition by hand rather than proving a real reachable race The local-variable capture is a harmless cosmetic improvement but not worth the complexity and shifting narrative. If genuine concurrent poll() NPEs are observed in practice, that warrants a separate, properly scoped fix. Thank you both for the thorough reviews. _Claude Code on behalf of mayurbm_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
