mayurbm commented on PR #25881:
URL: https://github.com/apache/camel/pull/25881#issuecomment-5493857895
@davsclaus Thank you for the detailed verification — both issues addressed:
**1. `GenericFileConverter` WARN actually removed**
The WARN block is now deleted from `convertTo()`. The linter had been
silently reverting it across branches; force-pushed to ensure the correct state
is on the remote.
**2. `StreamCachingHelper` WARN deduplicated per exchange**
Added exchange property guard `CamelStreamCacheWarnedWrappedFileNullBody`:
```java
if (body instanceof WrappedFile<?> wf && wf.getBody() == null
&& exchange.getProperty(WARNED_WRAPPED_FILE_NULL_BODY) == null) {
exchange.setProperty(WARNED_WRAPPED_FILE_NULL_BODY, Boolean.TRUE);
LOG.warn(...);
}
```
The flag is set on first fire — subsequent nodes in the same exchange skip
the WARN.
**Test updated** to use a multi-node route (`direct:start → log:step1 →
log:step2 → mock:result`) and verify the
`CamelStreamCacheWarnedWrappedFileNullBody` exchange property is set after
traversal (proving deduplication).
Local results: `camel-base-engine` + `camel-core` + `camel-file` full suites
pass with JDK 21 (2 new tests pass).
_Claude Code on behalf of mayurbm_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
