ammachado commented on PR #1729: URL: https://github.com/apache/camel-website/pull/1729#issuecomment-5498698985
Follow-up on the non-inline notes from the review: **Asciinema extension unexercised** — confirmed, no content uses `[asciinema]` yet. It's additive/opt-in so it can't regress anything today; landing a real page that uses it (or at least an end-to-end manual check) is tracked as a follow-up rather than blocking this PR. **Test suite not exercised in CI** — digging into this, the gap is actually broader than the `python3`-in-CI question: neither the root `yarn test` (which includes `record-cast-test.js`) nor `antora-ui-camel`'s `gulp test` (the DocSearch suite, etc.) is wired into `.github/workflows/pr.yaml` at all — the `checks` job only runs `check:links`, `check:html`, `check:redirects`. So `python3` availability is moot for now. Wiring the test suites into CI is worth doing but is scoped as a separate follow-up rather than expanding this PR further. **Licensing of `preview-src`** — confirmed: several of the new example pages (`404.adoc`, `admonitions.adoc`, `code.adoc`, `index.adoc`, `tabs.adoc`, `ui-model.yml`, `multirepo-ssg.svg`) are adapted from [bonitasoft/bonita-documentation-theme](https://github.com/bonitasoft/bonita-documentation-theme), which is MPL-2.0 — the same license `antora-ui-camel` already ships under (inherited from the Antora default UI since this subproject's creation). Added attribution in `d84cef15`-adjacent commit: a note in `antora-ui-camel/README.adoc`'s Copyright and License section, plus inline comments in `404.adoc`, `ui-model.yml`, and `multirepo-ssg.svg` (the most directly copied files) pointing back to the source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
