ramu11 commented on code in PR #26006: URL: https://github.com/apache/camel/pull/26006#discussion_r3911150437
########## components/camel-hivemq/pom.xml: ########## @@ -0,0 +1,71 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.camel</groupId> + <artifactId>components</artifactId> + <version>4.23.0-SNAPSHOT</version> + </parent> + + <artifactId>camel-hivemq</artifactId> + <packaging>jar</packaging> + <name>Camel :: HiveMQ</name> + <description>Camel HiveMQ MQTT Client support</description> + + <dependencies> Review Comment: The test log shows a clean **BUILD SUCCESS**: all 5 Integration Tests (`IT` classes) executed and passed via Failsafe, the Maven `sourcecheck` executions succeeded, and the artifact was packaged and installed into your local `.m2` repository without issues. The `sun.misc.Unsafe` warnings come from a transitive dependency (`jctools-core`) on newer JDKs and are completely normal and safe to ignore. --- ### Updated GitHub Reply to `@gnodet` Here is a ready-to-post update reflecting your actual test run: ```markdown Hi @gnodet, Thanks for catching that! I have added the arch-skipping properties to `components/camel-hivemq/pom.xml` so integration tests bypass `ppc64le` and `s390x` runners: ```xml <properties> <skipITs.ppc64le>true</skipITs.ppc64le> <skipITs.s390x>true</skipITs.s390x> </properties> ``` Ran `mvn install -Psourcecheck -pl components/camel-hivemq` locally; both unit and integration tests (including `HiveMQComponentPubSubIT`, `HiveMQEmptyPayloadIT`, etc.) passed cleanly with zero failures. The changes have been pushed and are ready for another review! ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
