Croway commented on PR #26039:
URL: https://github.com/apache/camel/pull/26039#issuecomment-5510929033

   > Thanks for the comments and the analysis, Fede. So the plan is:
   > 
   > 1. Drop `CamelLauncher.detectJarPath()`, call 
`LauncherHelper.getLauncherJarPath()` instead
   > 2. Use `Path.of(URI.create(...))` to normalize Windows paths in all three 
URL branches
   > 3. Tighten `isRunningFromLauncher()` to check filename only
   > 4. Extract `parseJarPath(String)` as package-private + add unit tests
   > 5. Forward JVM args in `getCamelCommand()`
   > 6. Log warning with raw URL on fallback
   > 
   > +Fixed the PR description Sounds good?
   
   yes, sounds reasonable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to