davsclaus commented on code in PR #25273:
URL: https://github.com/apache/camel/pull/25273#discussion_r3917341744
##########
core/camel-api/src/main/java/org/apache/camel/ai/CamelLangchain4jAttributes.java:
##########
@@ -25,4 +25,18 @@ public interface CamelLangchain4jAttributes {
String CAMEL_LANGCHAIN4J_EMBEDDING = "CamelLangChain4jEmbeddingsEmbedding";
String CAMEL_LANGCHAIN4J_EMBEDDING_VECTOR =
"CamelLangChain4jEmbeddingsVector";
String CAMEL_LANGCHAIN4J_TEXT_SEGMENT =
"CamelLangChain4jEmbeddingsTextSegment";
+
+ /**
+ * List of embeddings from a batch embedAll operation.
+ *
+ * @since 4.22
Review Comment:
`main` is `4.23.0-SNAPSHOT` and 4.22.0 is already released, so this constant
is introduced in 4.23.
```suggestion
* @since 4.23
```
##########
core/camel-api/src/main/java/org/apache/camel/ai/CamelLangchain4jAttributes.java:
##########
@@ -25,4 +25,18 @@ public interface CamelLangchain4jAttributes {
String CAMEL_LANGCHAIN4J_EMBEDDING = "CamelLangChain4jEmbeddingsEmbedding";
String CAMEL_LANGCHAIN4J_EMBEDDING_VECTOR =
"CamelLangChain4jEmbeddingsVector";
String CAMEL_LANGCHAIN4J_TEXT_SEGMENT =
"CamelLangChain4jEmbeddingsTextSegment";
+
+ /**
+ * List of embeddings from a batch embedAll operation.
+ *
+ * @since 4.22
+ */
+ String CAMEL_LANGCHAIN4J_EMBEDDINGS =
"CamelLangChain4jEmbeddingsEmbeddings";
+
+ /**
+ * List of text segments from a batch embedAll operation.
+ *
+ * @since 4.22
Review Comment:
Same here — introduced in 4.23.
```suggestion
* @since 4.23
```
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -493,13 +493,34 @@ If your code reads tool-related headers from the calling
exchange after agent in
you will need to adjust it. The agent's `Result<String>` (and the new
`CamelLangChain4jAgentToolExecutions`
header) is the intended way to observe tool execution results.
+=== camel-langchain4j-embeddings
Review Comment:
This (and the `=== camel-langchain4j-embeddingstore` additions further down)
should move to `camel-4x-upgrade-guide-4_23.adoc` under the "Upgrading Camel
4.22 to 4.23" section. 4.22.0 is already released, so the 4_22 guide will not
carry this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
