atiaomar1978-hub commented on PR #25495: URL: https://github.com/apache/camel/pull/25495#issuecomment-5515164164
## Review feedback addressed _Composer on behalf of atiaomar1978-hub (AI-generated)_ Thanks @davsclaus — all review items are now addressed in **6c7b7bc**: | Priority | Item | Status | |----------|------|--------| | Blocking | Regenerate dev-console descriptor for `details` field | **Done** in `ad1b12d` | | Major | Make `asJSon()` / `toJSon()` **default methods** on `CamelEvent` SPI | **Done** in `6c7b7bc` — minimal `type`/`timestamp`/`message` fallback; built-in events still override with rich JSON via `CamelEventJsonSupport` | | Minor | Upgrade guide entry | **Done** in `6c7b7bc` — `camel-4x-upgrade-guide-4_23.adoc` | | Minor | `details` duplicates flat fields | **Intentional** — flat fields kept for backwards compatibility; `details` holds the full structured JSON payload | ### CI / regen check Re-ran locally after the latest changes: ```bash mvn install -pl core/camel-console,catalog/camel-catalog -am -DskipTests mvn test -pl core/camel-core -am -Dtest=CamelEventJsonTest -Dsurefire.failIfNoSpecifiedTests=false ``` No uncommitted generated files — dev-console metadata from the earlier regen commit is still current. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
