gnodet commented on code in PR #26074:
URL: https://github.com/apache/camel/pull/26074#discussion_r3923591785
##########
components/camel-jpa/src/test/resources/profiles/hibernate/META-INF/persistence.xml:
##########
@@ -79,6 +82,18 @@
</properties>
</persistence-unit>
+ <persistence-unit name="keyvalueDb" transaction-type="RESOURCE_LOCAL">
+ <provider>org.hibernate.jpa.HibernatePersistenceProvider</provider>
+
+ <class>org.apache.camel.processor.keyvalue.jpa.KeyValueEntry</class>
+
+ <properties>
+ <property name="jakarta.persistence.jdbc.driver" value="org.h2.Driver"/>
+ <property name="jakarta.persistence.jdbc.url"
value="jdbc:h2:./target/keyvalueTest;DB_CLOSE_DELAY=-1"/>
Review Comment:
This unit uses `jakarta.persistence.jdbc.driver` /
`jakarta.persistence.jdbc.url` while all 5 other units in this file use
`hibernate.connection.driver_class` / `hibernate.connection.url`. It's also the
only unit missing `hibernate.dialect`. Consider aligning for consistency:
```suggestion
<properties>
<property name="hibernate.dialect"
value="org.hibernate.dialect.H2Dialect"/>
<property name="hibernate.connection.driver_class"
value="org.h2.Driver"/>
<property name="hibernate.connection.url"
value="jdbc:h2:./target/keyvalueTest;DB_CLOSE_DELAY=-1"/>
<property name="hibernate.hbm2ddl.auto" value="create"/>
</properties>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
