atiaomar1978-hub commented on PR #26055: URL: https://github.com/apache/camel/pull/26055#issuecomment-5546666598
Addressed all @gnodet review comments in `054c4fd`: 1. **camel-ai-observability self-reference** — excluded from `hasGenAiDependency()`; `alreadyHasAiObservability()` prevents duplicate entries in `Run.java`'s `ArrayList` 2. **Broad `-ai-` heuristics** — replaced with `CamelCatalog.modelFromMavenGAV()` + catalog `ai` label 3. **camel.aiObservability known-deps entry** — documented inline (same pattern as `camel.opentelemetry`) 4. **AI_OBSERVABILITY_ENABLED visibility** — narrowed to package-private 5. **Mockito in tests** — replaced with real `DefaultCamelCatalog` All 9 `GenAiDependencyHelperTest` tests pass locally. _Cursor Agent on behalf of atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
