davsclaus opened a new pull request, #26142:
URL: https://github.com/apache/camel/pull/26142

   ## Summary
   
   - Fixes `camel-spring-ai-image` and `camel-docling` CI failures caused by 
`@DisabledIfSystemProperty(named = "ci.env.name")` not working in forked test 
JVMs
   - Adds a `ci-env-name` Maven profile in `parent/pom.xml` that propagates 
`ci.env.name` to both surefire and failsafe forked JVMs when it is defined — 
fixing the pattern used in ~99 test files across the project
   - Fixes `SpringAiImageOllamaIT` to pull `x/flux2-klein:4b` (the actual image 
model) rather than the default `granite4:3b` chat model, so the test works 
correctly if it ever runs locally with the model installed
   
   ## Root cause
   
   `ci.env.name=github.com` is set via `MVND_OPTS` which gets expanded on the 
Maven command line. This makes it a Maven user property, but Maven 
Failsafe/Surefire 3.x does **not** automatically forward user properties to 
forked test JVMs. So `@DisabledIfSystemProperty(named = "ci.env.name", matches 
= ".*")` never fired in CI — the tests ran instead of being skipped — and 
`SpringAiImageOllamaIT` failed because the Ollama container only pulled 
`granite4:3b` (the default), not `x/flux2-klein:4b`.
   
   ## Test plan
   
   - [ ] CI should show `SpringAiImageOllamaIT` and `camel-docling` ITs as 
skipped (not failed) in the GitHub Actions run
   - [ ] Locally (without `ci.env.name` set), tests with this annotation still 
run as expected
   
   _Claude Code on behalf of davsclaus_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to